Re: [Xen-devel] [PATCHv6] 03/28] build: use generated Kconfig options for Xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.11.15 at 18:51, <cardoe@xxxxxxxxxx> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -26,6 +26,9 @@ default: build
>  .PHONY: dist
>  dist: install
>  
> +.PHONY: build
> +build:: $(BASEDIR)/include/config/auto.conf
> +
>  .PHONY: build install uninstall clean distclean cscope TAGS tags MAP gtags

I do not see why you need to add build to PHONY's dependencies
another time.

> @@ -227,9 +230,14 @@ kconfig := silentoldconfig oldconfig config menuconfig 
> defconfig \
>  $(kconfig):
>       $(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=$(XEN_TARGET_ARCH) 
> $@
>  
> -$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf.cmd
> +$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf.cmd 
> $(BASEDIR)/.config
>       $(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile 
> ARCH=$(XEN_TARGET_ARCH) silentoldconfig
>  
>  # Allow people to just run `make` as before and not force them to configure
> -$(BASEDIR)/.config $(BASEDIR)/include/config/auto.conf.cmd: ;
> +$(BASEDIR)/.config:
>       $(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile 
> ARCH=$(XEN_TARGET_ARCH) defconfig

This should be one of the oldconfig targets now, shouldn't it?

> +# Break the dependency chain for the first run
> +$(BASEDIR)/include/config/auto.conf.cmd: ;
> +
> +-include $(BASEDIR)/include/config/auto.conf.cmd

The comment is quite a bit different in Linux, and seems to make more
sense. Also note how Linux has an empty rule for $(KCONFIG_CONFIG),
a variable which iirc you defined in an earlier patch and hence perhaps
you should be using here.

> --- a/xen/include/xen/config.h
> +++ b/xen/include/xen/config.h
> @@ -12,6 +12,8 @@
>  #endif
>  #include <asm/config.h>
>  
> +#include <generated/autoconf.h>

First thing perhaps?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel