Re: [Xen-devel] [PATCH v2 02/11] xen/arm: vgic-v3: Don't try to emulate IROUTER which doesn't exist in the spec

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 24/11/15 17:17, Ian Campbell wrote:
> On Wed, 2015-11-18 at 17:27 +0000, Julien Grall wrote:
> 
> Subject: ... which do not exist in the ...
> 
>> The range of valid IROUTER<n> are n = 32 - 1019 (see 8.9.13 in IHI 0069A)
>> which correspond to the offset 0x6100-0x7FD8.
>>
>> Other offset are invalid and therefore should not be emulated.
> 
> "offsets"
> 
>>
>> Also remove the now unused label read_as_zero_64 and write_ignore_64.
>>
>> Note that GICD_IROUTER is kept to accomadate the GICv3 drivers which has
> 
> "accommodate"
> 
>> been in part taken from Linux.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Accesses to 0x6000-0x60FF are going to be noisy now, I suppose that is OK.

Well, those registers are reserved so the guests are not supposed to
access them.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thank you!

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel