Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/11/15 11:05, Jan Beulich wrote:
> ... or when the guest has the XSAVE feature hidden by CPUID policy.
> Not doing so is at best confusing to guests.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

These changes here are an improvement (so I don't object to taking them
ahead of my fullblown levelling series), but they are incomplete.

xsaveopt, xsavec, xsetbv1, xsaves, avx and mpx depend on xsave.
fma, fma4, f16c, avx2 and xop depend on avx.

My levelling series actually introduces a dependency tree to properly
evaluate the knockon effects of disabling certain features.  I am unsure
whether it is worth your time to split xsave and avx here, but I
certainly wouldn't recommend making it any finer-grained at this stage.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel