Re: [Xen-devel] [PATCH] tools/hotplug: quote all variables in vif-bridge

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-11-19 at 08:32 +0000, Olaf Hering wrote:
> Cosmetics: most of the variables used in vif-bridge are already quoted.
> Add quoting also to the remaining shell variables.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxxx

(I imagine much hilarity would ensue all over the place if a Linux netdev
actually had a name with a space in it...)

> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Âtools/hotplug/Linux/vif-bridge | 6 +++---
> Â1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-
> bridge
> index 3d72ca4..6956dea 100644
> --- a/tools/hotplug/Linux/vif-bridge
> +++ b/tools/hotplug/Linux/vif-bridge
> @@ -68,7 +68,7 @@ else
> Âfi
> Â
> ÂRET=0
> -ip link show dev $bridge 1>/dev/null 2>&1 || RET=1
> +ip link show dev "$bridge" 1>/dev/null 2>&1 || RET=1
> Âif [ "$RET" -eq 1 ]
> Âthen
> ÂÂÂÂÂfatal "Could not find bridge device $bridge"
> @@ -77,7 +77,7 @@ fi
> Âcase "$command" in
> ÂÂÂÂÂonline)
> ÂÂÂÂÂÂÂÂÂsetup_virtual_bridge_port "$dev"
> -ÂÂÂÂÂÂÂÂset_mtu $bridge $dev
> +ÂÂÂÂÂÂÂÂset_mtu "$bridge" "$dev"
> ÂÂÂÂÂÂÂÂÂadd_to_bridge "$bridge" "$dev"
> ÂÂÂÂÂÂÂÂÂ;;
> Â
> @@ -88,7 +88,7 @@ case "$command" in
> Â
> ÂÂÂÂÂadd)
> ÂÂÂÂÂÂÂÂÂsetup_virtual_bridge_port "$dev"
> -ÂÂÂÂÂÂÂÂset_mtu $bridge $dev
> +ÂÂÂÂÂÂÂÂset_mtu "$bridge" "$dev"
> ÂÂÂÂÂÂÂÂÂadd_to_bridge "$bridge" "$dev"
> ÂÂÂÂÂÂÂÂÂ;;
> Âesac

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel