Re: [Xen-devel] [PATCH] libxl: correct bug in domain builder regarding page tables for pvh

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Nov 19, 2015 at 05:11:08PM +0100, Juergen Gross wrote:
> Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of
> domain builder's page table handler") dropped a special case for pvh
> resulting in page tables being mapped read-only. This led to a panic
> of the domain in early boot.
> 
> Correct this error.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Boris, can you test this as well? 

> ---
>  tools/libxc/xc_dom_x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> index 7279fa2..5ff33ca 100644
> --- a/tools/libxc/xc_dom_x86.c
> +++ b/tools/libxc/xc_dom_x86.c
> @@ -372,7 +372,7 @@ static x86_pgentry_t get_pg_prot_x86(struct xc_dom_image 
> *dom, int l,
>      unsigned m;
>  
>      prot = domx86->params->lvl_prot[l];
> -    if ( l > 0 )
> +    if ( l > 0 || dom->pvh_enabled )
>          return prot;
>  
>      for ( m = 0; m < domx86->n_mappings; m++ )
> -- 
> 2.6.2
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel