Re: [Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Nov 17, 2015 at 03:21:39PM +0000, Ian Campbell wrote:
> On Tue, 2015-11-17 at 15:16 +0000, Wei Liu wrote:
> > On Tue, Nov 17, 2015 at 03:08:47PM +0000, Wei Liu wrote:
> > > The rune is
> > > 
> > >   sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c
> > > 
> > 
> > Hmm... It looks like this rune alone doesn't cover all situations.
> > 
> >  $ ack-grep 'libxl__sprintf\(gc' | wc -l 
> >  43
> > 
> > Let me see if I can refine it a bit or use multiple runes to replace all
> > libxl__sprintf.
> 
> Coccinelle would probably work quite well for this particular case.
> 

Unfortunately no. Coccinelle doesn't support variable arguments,
otherwise I would have used it already.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel