Re: [Xen-devel] [RFC PATCH 2/6] libxl: stop using libxl__xs_mkdir() for ~/control/shutdown

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-11-16 at 13:16 +0000, Paul Durrant wrote:
> >Â
> > > +ÂÂÂÂret = vasprintf(&s, fmt, ap);
> > > ÂÂÂÂÂif (ret == -1) {
> > > ÂÂÂÂÂÂÂÂÂreturn -1;
> > > ÂÂÂÂÂ}
> > > ÂÂÂÂÂxs_write(ctx->xsh, t, path, s, ret);
> > > +ÂÂÂÂif (perms)
> > > +ÂÂÂÂÂÂÂÂxs_set_permissions(ctx->xsh, t, path, perms, num_perms);
> > 
> > This can fail, can't it? (OTOH so can xs_write, so maybe there is some
> > reason we apparently don't care for such things here?)
> > 
> 
> That's a good point. I would have thought wiring an xs_write() failure
> back through to the caller would be a good idea (and same goes for
> xs_set_permissions, I guess).

git tells me it has been this way since libxl was first committed to the
repo. I can't think of a good reason to squash these errors.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel