Re: [Xen-devel] [PATCH] x86/IO-APIC: adjust setting of destinations

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/11/15 17:41, Jan Beulich wrote:
>>>> On 13.11.15 at 17:26, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 13/11/15 15:44, Jan Beulich wrote:
>>> setup_IO_APIC_irqs() runs before APs get brought up, so using
>>> desc->arch.cpu_mask as best risks it being either empty or having bits
>>> for CPUs other than the BP set. Just use the APIC ID of the only
>>> online CPU directly. Replace a stray hard_smp_processor_id() at once.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Surely this stray hard_smp_processor_id() needs to be merged into your
>> previous patch to remove hard_smp_processor_id() ?
> Actually I should have said that the other one depends on this one.
> Which one to put that hunk in really doesn't matter much.

It would be cleaner to deal with all hard_smp_processor_id() together,
as the other hunk is this patch is a far more clear candidate for backport.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel