Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-11-13 at 18:16 +0100, Roger Pau Monnà wrote:
> El 13/11/15 a les 17.57, Ian Campbell ha escrit:
> > On Fri, 2015-11-13 at 15:16 +0000, Ian Campbell wrote:
> > > 
> > > On FreeBSD hypercall->retval is in the XEN_ERRNO_* space. But I think
> > > we
> > > probably want to map onto the FreeBSD ERRNO space, IIRC we decided on
> > > this
> > > approach, rather than converting all our callers to the XEN_ERRNO_*
> > > space,
> > > in a previous discussion.
> > 
> > Roger, can you confirm whether or not something on FreeBSD translated
> > the
> > XEN_ERRNO errors into the BSD errno space? If so, then where is it? I
> > looked in FreeBSD's privcmd.c and in libxc and failed to find it...
> 
> Yes, the translation is done in the privcmd driver:
> 
> https://github.com/freebsd/freebsd/blob/master/sys/dev/xen/privcmd/privcm
> d.c#L242

Thanks, I was looking for a big table but it's out of line in another file
so I missed it.


> So errors returned from the ioctl (in errno) are in the BSD space. I
> still have to implement the error codes distributed from the Xen public
> headers, right now we have a custom Xen error translation:
> 
> https://github.com/freebsd/freebsd/blob/master/sys/xen/error.h
> 
> Roger.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel