Re: [Xen-devel] [PATCH v3 0/4] docs: Document xenstore paths

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> Sent: 13 November 2015 16:10
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH v3 0/4] docs: Document xenstore paths
> 
> Paul Durrant writes ("[Xen-devel] [PATCH v3 0/4] docs: Document xenstore
> paths"):
> > Patch #1 documents paths, some already in used by XenServer, which can
> be
> > used by guests to advertise contol capabilities.
> 
> Thanks for these patches.  I am pleased to see what for upstream Xen
> are new facilities and new protocol features, and to see you
> upstreaming this XenServer work.
> 
> I think though that the docs patches need a slightly different
> `angle', and are lacking some crucial information.
> 
> Firstly, the patch descriptions say `Document xenstore paths ...'
> But from the point of view of upstream xen.git, these are new paths.
> So I think the patch titles should be `Introduce xenstore paths for ...'
> 

Ok.

> The documents need to acknowledge that the paths may not be supported
> by either end.  So rather than "the toolstack will create", say "the
> toolstack may create", for example.
> 

Sure.

> And the documents themselves should then clearly state what the
> behaviour should be on the part of a toolstack which finds the
> information missing, or set to a particular values.
> 

Yes, I think that would be useful to add. In trying to implement the associated 
changed in libxl I can see it would be valuable :-)

> Likewise, they should document the expected behaviour of a guest which
> finds that the entries are missing or cannot be written for
> permissions reasons.
> 

In general from the guest PoV there's not a lot it can do if a path is not 
writable, but I'll call that out.

> I have a few patch-specific comments too, which I will reply to in the
> individual patches.
> 

Thanks,

  Paul

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel