Re: [Xen-devel] [PATCH v3 2/2] arm: export platform_op XENPF_settime64

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 11 Nov 2015, Julien Grall wrote:
> On 11/11/15 18:14, Stefano Stabellini wrote:
> > On Wed, 11 Nov 2015, Julien Grall wrote:
> >>> diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
> >>> index 1418092..aa0fde6 100644
> >>> --- a/xen/arch/arm/vtimer.c
> >>> +++ b/xen/arch/arm/vtimer.c
> >>> @@ -22,13 +22,13 @@
> >>>  #include <xen/timer.h>
> >>>  #include <xen/sched.h>
> >>>  #include <xen/perfc.h>
> >>> +#include <asm/div64.h>
> >>>  #include <asm/irq.h>
> >>>  #include <asm/time.h>
> >>>  #include <asm/gic.h>
> >>>  #include <asm/vgic.h>
> >>>  #include <asm/regs.h>
> >>>  
> >>> -extern s_time_t ticks_to_ns(uint64_t ticks);
> >>
> >> If it's a valid change you should mention it in the commit message
> >> because it's not related to this patch.
> >>
> >> Otherwise it looks spurious...
> > 
> > Sorry, that's not a valid change anymore, I meant to remove it. Thanks
> > for checking.
> 
> If it wasn't clear, I think this change is valid. Defining the prototype
> in the C file is a call to have the prototype not matching the declaration.
> 
> Any prototypes should be declared in the header and not that way.
> 
> I'm fine with this, but it should be mentioned in the commit message.

It might be a decent change to have, but it is not needed by this patch
anymore, so if anything it should go in on its own.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel