[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: make compat_iret() domain crash cases distinguishable



On 30/10/15 17:46, Jan Beulich wrote:
> Rather than issuing a (mostly) useless separate message, rely on
> domain_crash() providing enough data, and leverage the line number
> information it prints.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

The messages are not completely useless, and they do save a round-trip
to the debug symbols (which can be a very long RTT when dealing with
customers).

I agree that moving the domain_crash()'s is a good idea, but can we get
away with just demoing the gprintk()s to gdprintk()s ?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.