Re: [Xen-devel] [PATCH v2] tools/hotplug: xendomains.service conflicts with libvirt

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 29, 2015 at 11:02:54AM +0000, Olaf Hering wrote:
> xendomains will manage guests behind libvirts back:
> - libvirt starts a guest
> - that guest can be "managed" by libvirt and xl at the same time
> - when xendomains runs on shutdown it will save the guest using xl
>   libvirt does not know about this
> - when xendomains runs on boot it will restore the saved guest using xl
>   libvirt does not know about this, it will just fail to manage the
>   restored guest
> 
> To prevent xendomains from interfering with libvirt add a Conflicts= to
> xendomains.service. It will cause libvirt to be stopped if xendomains is
> started manually with 'systemctl start'

Missing period at the end.

> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> v2: correct typo, it has to be libvirtd.service
> 
>  tools/hotplug/Linux/systemd/xendomains.service.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in 
> b/tools/hotplug/Linux/systemd/xendomains.service.in
> index 66e2065..c7bfb61 100644
> --- a/tools/hotplug/Linux/systemd/xendomains.service.in
> +++ b/tools/hotplug/Linux/systemd/xendomains.service.in
> @@ -5,6 +5,7 @@ After=proc-xen.mount xenstored.service xenconsoled.service 
> xen-init-dom0.service
>  After=network-online.target
>  After=remote-fs.target
>  ConditionPathExists=/proc/xen/capabilities
> +Conflicts=libvirtd.service
>  

I confirm this is the service name provided by libvirt.git.

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

>  [Service]
>  Type=oneshot

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel