Re: [Xen-devel] [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Oct 21, 2015 at 11:36:23AM +0100, Paul Durrant wrote:
> If the frontend indicates it's capable (see netif.h for details) and an
> skb has an L4 or L3 hash value then pass the value to the frontend in
> a xen_netif_extra_info segment.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

>  static int xenvif_rx_ring_slots_needed(struct xenvif *vif)
>  {
> -     if (vif->gso_mask)
> -             return DIV_ROUND_UP(vif->dev->gso_max_size, PAGE_SIZE) + 1;
> +     int needed;
> +
> +     if (vif->gso_mask || vif->gso_prefix_mask)

It seems like this line should become a patch for -stable?

>               xenvif_add_frag_responses(queue, status,
> diff --git a/drivers/net/xen-netback/xenbus.c 
> b/drivers/net/xen-netback/xenbus.c
> index 2fa8a16..a31bcee 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -1037,6 +1037,11 @@ static int read_xenbus_vif_flags(struct backend_info 
> *be)
>               val = 0;
>       vif->multicast_control = !!val;
>  
> +     if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-hash",
> +                      "%d", &val) < 0)
> +             val = 0;

Again, feel free to retain my reviewed-by if this changes in next
version.

Wei.

> +     vif->hash_extra = !!val;
> +
>       return 0;
>  }
>  
> -- 
> 2.1.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel