Re: [Xen-devel] [PATCH] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.10.15 at 18:13, <julien.grall@xxxxxxxxxx> wrote:
> On 22/10/15 16:48, Jan Beulich wrote:
>>>>> On 22.10.15 at 17:43, <julien.grall@xxxxxxxxxx> wrote:
>>> @@ -477,7 +477,7 @@ p2m_pod_offline_or_broken_replace(struct page_info *p)
>>>  
>>>      free_domheap_page(p);
>>>  
>>> -    p = alloc_domheap_page(d, PAGE_ORDER_4K);
>>> +    p = alloc_domheap_page(d, 0);
>> 
>> I realize that this is the easiest fix, but I think here we instead want
>> something like
> 
> It sounds sensible to me to re-allocate the page on the same numa node.
> 
> I will send another version of this patch. Although, I would appreciate
> if someone can test it because I don't have any NUMA platform.

To test this code path, memory hut unplug would need to be
supported by the platform too, or you'd have to manage to be
unlucky for your system to have a faulty memory page in the
"right" slot.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel