[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: He Chen <he.chen@xxxxxxxxxxxxxxx>
- Date: Fri, 16 Oct 2015 16:24:20 +0800
- Cc: Olaf Hering <olaf@xxxxxxxxx>, keir@xxxxxxx, ian.campbell@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, wei.liu2@xxxxxxxxxx
- Delivery-date: Fri, 16 Oct 2015 08:24:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
- Mail-followup-to: Jan Beulich <JBeulich@xxxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>, wei.liu2@xxxxxxxxxx, keir@xxxxxxx, ian.campbell@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx
On Thu, Oct 15, 2015 at 09:47:37AM -0600, Jan Beulich wrote:
>
> Ah, yes, in cases like this it should always be followed by return
> (or whatever else is suitable). Sorry for not having spotted this
> during review.
>
Sorry for this bug. Is it proper to fix this bug by just adding a
return after ASSERT_UNREACHABLE? Or do some changes in
ASSERT_UNREACHABLE?
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
