Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

[Insu Yun <wuninsu@xxxxxxxxx>]

I changed patch with valid format.

On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun <wuninsu@xxxxxxxxx> wrote:

Since vzalloc can be failed in memory pressure,
writes -ENOMEM to xenstore to indicate error.

Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx>
---
Âdrivers/net/xen-netback/xenbus.c | 6 ++++++
Â1 file changed, 6 insertions(+)

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 929a6e7..56ebd82 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -788,6 +788,12 @@ static void connect(struct backend_info *be)
    /* Use the number of queues requested by the frontend */
    be->vif->queues = vzalloc(requested_num_queues *
                 sizeof(struct xenvif_queue));
+Â Â Â Âif (!be->vif->queues) {
+Â Â Â Â Â Â Â Âxenbus_dev_fatal(dev, -ENOMEM,
+Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "allocating queues");
+Â Â Â Â Â Â Â Âreturn;

I didn't use goto err, because another error handling is not required
Â

+Â Â Â Â}
+
    be->vif->num_queues = requested_num_queues;
    be->vif->stalled_queues = requested_num_queues;

--
1.9.1

--

Regards

Insu Yun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel