Re: [Xen-devel] [PATCH v7 3/3] tools & docs: add tools and docs support for Intel CDP

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-10-13 at 16:53 +0800, He Chen wrote:
> @@ -8445,29 +8447,46 @@ out:
>      return rc;
>  }
>  
> -static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t
> socketid)
> +static void psr_cat_print_one_domain_cbm_type(uint32_t domid, uint32_t
> socketid,
> +                                              libxl_psr_cbm_type type)
>  {
> -    char *domain_name;
>      uint64_t cbm;
> +        if (!libxl_psr_cat_get_cbm(ctx, domid, type, socketid, &cbm))
> +            printf("%#16"PRIx64, cbm);
> +        else
> +            printf("%16s", "error");

Coding style is 4 space indentation, here you appear to have 8 for the
first level and 4 for the second level of indentation.

With that fixed:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel