Re: [Xen-devel] [PATCH v7 12/32] xen/x86: add bitmap of enabled emulated devices

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.10.15 at 17:48, <roger.pau@xxxxxxxxxx> wrote:
> @@ -517,6 +520,22 @@ int arch_domain_create(struct domain *d, unsigned int 
> domcr_flags,
>                 d->domain_id);
>      }
>  
> +    if ( (config->emulation_flags & ~XEN_X86_EMU_ALL) != 0 )
> +    {
> +        printk(XENLOG_G_ERR "d%d: Invalid emulation bitmap: %#x\n",
> +               d->domain_id, config->emulation_flags);
> +        return -EINVAL;
> +    }
> +    if ( (is_hvm_domain(d) && config->emulation_flags != XEN_X86_EMU_ALL) ||
> +         (is_pv_domain(d) && config->emulation_flags != 0) )

How about PVH? At this point of the series I'm sure it also needs all flags
clear? In which case this should become

    if ( is_hvm_domain(d) ? (config->emulation_flags != XEN_X86_EMU_ALL)
                          : (config->emulation_flags != 0) )

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel