Re: [Xen-devel] [PATCH OSSTEST 2/5] cs-adjust-flight: Add job-status to report job stats

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-10-06 at 15:44 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST 2/5] cs-adjust-flight: Add job
> -status to report job stats"):
> > The return code of sg-run-job does not reflect the state of the job,
> > which is instead written to the database. For the benefit of running
> > tests in a loop until failure add a command to retrieve the status to
> > stdout.
> ...
> > +job_status() {
> > +    flight=$1; shift
> > +    job=$1; shift
> > +
> > +    status=$(OSSTEST_CONFIG=$config \
> > +           ./cs-adjust-flight $flight job-status $job)
> > +    echo "$status"
> > +}
> 
> This is rather odd.  Why do you capture the value in a variable and
> then pass it to echo ?  You could just let the job_status command
> print its output directly.

It was previously echo "${status#* }" (or something like that). I should
have changed it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel