Re: [Xen-devel] [PATCH v5 3/3] tools & docs: add tools and docs support for Intel CDP

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Tue, Sep 29, 2015 at 02:47:39PM +0100, Ian Campbell wrote:
> On Mon, 2015-09-28 at 16:29 +0800, He Chen wrote:
> > -"17.14 - Platform Shared Resource Monitoring: Cache Monitoring Technology".
> > +"Platform Shared Resource Monitoring: Cache Monitoring Technology".
> 
> I think these will clash with Cheng Pao's PSR updates, which have already
> been applied.

Yes, this can be eliminated in this series.

>  
> > 
> > +Code/Data Prioritization (CDP) Technology is an extension of CAT, which is
> 
> Other bits of documentation added here seem to suggest it is actually an
> extension of CBM, is that right?

Yes, from technical perspective, CDP is an extension on CAT. But even though,
I'd really like it being put in a separated section, making it easy for
user to find it out. The new section can of course refers to CAT section, just
like what we did for MBM (which is an extension of CMT).

> 
> > diff --git a/tools/libxc/include/xenctrl.h
> > b/tools/libxc/include/xenctrl.h
> > index 2000f12..8f4acec 100644
> > --- a/tools/libxc/include/xenctrl.h
> > +++ b/tools/libxc/include/xenctrl.h
> > @@ -2794,7 +2794,9 @@ enum xc_psr_cmt_type {
> >  typedef enum xc_psr_cmt_type xc_psr_cmt_type;
> >  
> >  enum xc_psr_cat_type {
> > -    XC_PSR_CAT_L3_CBM = 1,
> > +    XC_PSR_CAT_L3_CBM  = 1,
> > +    XC_PSR_CAT_L3_CODE = 2,
> > +    XC_PSR_CAT_L3_DATA = 3,
> 
> If CDP is an extension of CBM, then would CBM_CODE + CBM_DATA be better
> names (more important in the libxl API than here)

Agreed.

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel