Re: [Xen-devel] [PATCH v7] run QEMU as non-root

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("Re: [PATCH v7] run QEMU as non-root"):
> On Fri, 7 Aug 2015, Wei Liu wrote:
> > Please use for / while to loop.
> 
> The goto retry loop is a very common patter for error handling, but I
> can turn it into a loop if you are keen on it.

I'm afraid I agree with Wei here.

> > Also you might want to save and restore errno.
> 
> Across the getpwnam_r call? Or across the loop? Or across the function
> libxl__dm_runas_helper?

I don't understand either.  Also I don't understand why you set errno
to 0.
> 
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel