Re: [Xen-devel] [PATCH v6 24/29] xen/x86: allow HVM guests to use hypercalls to bring up vCPUs

[Tim Deegan <tim@xxxxxxx>]

At 01:09 -0600 on 29 Sep (1443488980), Jan Beulich wrote:
> >>> On 28.09.15 at 18:09, <roger.pau@xxxxxxxxxx> wrote:
> > El 21/09/15 a les 17.44, Jan Beulich ha escrit:
> >>>>> On 04.09.15 at 14:09, <roger.pau@xxxxxxxxxx> wrote:
> >>> +    if ( hvm_paging_enabled(v) && !paging_mode_hap(v->domain) )
> >>> +    {
> >>> +        /* Shadow-mode CR3 change. Check PDBR and update refcounts. */
> >>> +        struct page_info *page = get_page_from_gfn(v->domain,
> >>> +                                 v->arch.hvm_vcpu.guest_cr[3] >> 
> >>> PAGE_SHIFT,
> >>> +                                 NULL, P2M_ALLOC);
> >>
> >> P2M_ALLOC but not P2M_UNSHARE?
> >
> > This is a copy of what's done in hvm_set_cr3 when shadow mode is enabled.
> 
> As said on IRC - sadly we have to mem-sharing maintainer to ask. I
> wonder whether the past or current x86/mm maintainer would know
> - Tim, George?

Memory sharing requires HAP, so it makes no difference here.
Seems like it ought to be P2M_UNSHARE, though, for consistency.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel