Re: [Xen-devel] [PATCH v6 2/2] xen/arm: support gzip compressed kernels

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 21/09/2015 23:51, Stefano Stabellini wrote:
> Changes in v6:
> - use vmap to map pages
> - free old module and update mod->start and mod->size from
> kernel_decompress
I was expecting you to drop my Reviewed-by given those changes.

> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index f641b12..ad7e6bc 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
[...]


> +static __init uint32_t output_length(char *image, unsigned long image_len)
> +{
> +    return *(uint32_t *)&image[image_len - 4];
> +}
> +
> +static __init int kernel_decompress(struct bootmodule *mod)
> +{
[...]

> +    mfn = _mfn(page_to_mfn(pages));
> +    output = __vmap(&mfn, 1 << kernel_order_out, 1, 1, PAGE_HYPERVISOR);
You may want to use vmap here which is a wrapper to __vmap and will 
setup the granularity, align, and flags automatically for you.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel