Re: [Xen-devel] [PATCH v6 17/29] xen/x86: allow disabling the emulated PIC

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.09.15 at 14:08, <roger.pau@xxxxxxxxxx> wrote:
> @@ -425,6 +431,9 @@ void vpic_reset(struct domain *d)
>  
>  void vpic_init(struct domain *d)
>  {
> +    if ( !has_vpic(d) )
> +        return;

vpic_reset() above this function as well as functions further down
in the source file aren't static, yet you aren't adding guards to them.
I think here and in other similar patches you should, in the commit
message, give reasons for any one not obviously being excluded
(e.g. because used only for handling intercepts which aren't getting
enabled) from the set needing such.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel