Re: [Xen-devel] [PATCH v7 06/28] xen/arm: ITS: Add helper functions to manage its_devices

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 18/09/15 14:08, vijay.kilari@xxxxxxxxx wrote:
> +static void its_remove_device(struct its_device *dev)
> +{
> +    if ( dev )
> +        rb_erase(&dev->node, &rb_its_dev);

Either the caller or this function has to take the lock which protect
the RB-tree.

If it's the caller, please add an ASSERT to check the lock is taken. If
not, you know what to do ;).

Regards,

> +}
> +

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel