Re: [Xen-devel] [PATCH v2 0/4] Fix tools/xen-mceinj to handle >=4GB guest memory

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Haozhong Zhang writes ("[PATCH v2 0/4] Fix tools/xen-mceinj to handle >=4GB 
guest memory"):
> The existing xen-mceinj can not inject MCE through MSR_MCI_ADDR to a
> domain w/ more than 4GB memory, e.g. if domain 0 has more than 4GB
> memory, the execution of the command
>         xen-mceinj -d 0 -t 0 -p 0x2721a900
> will fail w/ a message "Failed to get pfn list ffffffff: Operation not
> supported".

xen-mceinj is a test utility, not a piece of code run in projection.
Accordingly, I don't think it needs a very thorough review.

I have had a quick look at the parts of this in tools/ and saw nothing
untoward.  I am not qualified to review the design but I hope
hypervisor and x86 maintaintainers will do that.

So as far as tools patches go,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Hypervisor and x86 maintainers: feel free to commit the tools parts of
this along with the hypervisor changes, subject to your own design and
code review and acks.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel