Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.09.15 at 15:42, <haozhong.zhang@xxxxxxxxx> wrote:
> On Tue, Sep 15, 2015 at 07:24:34AM -0600, Jan Beulich wrote:
>> >>> On 15.09.15 at 10:29, <haozhong.zhang@xxxxxxxxx> wrote:
>> > +                mfn = mfn_x(get_gfn(d, gpfn, &t));
>> > +
>> > +                if (mfn == INVALID_MFN) {
>> > +                    put_domain(d);
>> > +                    return x86_mcerr("do_mca inject: illegal MSR value",
>> > +                                     -EINVAL);
>>
>> This message should be better distinguishable from the one further
>> down (or else it's pretty pointless) - perhaps you mean GPFN instead
>> of MSR?
>>
> 
> Yes, I'll change it to "do_mca_inject: illegal GPFN".

I'd suggest "wrong" or "bad" instead of "illegal".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel