Re: [Xen-devel] [PATCH for-4.6] libxl: handle read-only drives with qemu-xen

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("[PATCH for-4.6] libxl: handle read-only drives with 
qemu-xen"):
> The current libxl code doesn't deal with read-only drives at all.
> 
> Upstream QEMU and qemu-xen only support read-only cdrom drives: make
> sure to specify "readonly=on" for cdrom drives and return error in case
> the user requested a non-cdrom read-only drive.

This should have:

 * an XSA
 * a credit

> +                if (!disks[i].readwrite) {
> +                    LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "QEMU doesn't support 
> read-only disk drivers");
> +                    return ERROR_INVAL;

This message should refer to `qemu-xen' specifically.  The user can
get the desired behaviour by going back to qemu-xen-traditional...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel