Re: [Xen-devel] [OSSTest Nested v12 06/21] Add new function of 'host_install_postboot_complete'

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Robert Ho writes ("[OSSTest Nested v12 06/21] Add new function of 
'host_install_postboot_complete'"):
> This function is called to add 'osstest-confirm-booted' service
> in target's start up services.
> Previously, this was dircetly done by
> target_cmd_root($ho, "update-rc.d osstest-confirm-booted start 99 2 .")
> 
> Here wrapper it because more than one place (ts-host-install
>  and ts-nested-setup) will need this, so wrapper it
>  to avoid open code.

The commit message describes what ought to be done, ore or less.
(Although `wrapper' is wrong: the terminology is `break out'; wrapping
refers to the design pattern of making a thin wrapper function for
another function.)

But the actual code introduces another copy.  You should combine this
patch with the next patch.  Ie, have one patch which moves the
`confirm-booted' invocation into a subroutine.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel