[Xen-devel] [BUG] xenctrl.h : error with xc_error_code declaration

[SÃbastien FrÃmal <sebastien.fremal@xxxxxxxxx>]

Hello,

I just write to signal a bug and its solution. I installed the 14.04 LTS ubuntu version and installed the xen version through synaptic. As I'm developping modules for Xen I also installed the xen dev package. The installed Xen version is 4.4.2.

I tried to compile one of my C files including xenctrl.h but I got the following errors :
In file included from ../modules/gntring/libgntring4.c:12:0:
/usr/include/xenctrl.h:122:14: error: use of enum âxc_error_codeâ without previous declaration
Âtypedef enum xc_error_code xc_error_code;
ÂÂÂÂÂÂÂÂÂÂÂÂÂ ^
/usr/include/xenctrl.h:122:41: error: invalid type in declaration before â;â token
Âtypedef enum xc_error_code xc_error_code;
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ^
/usr/include/xenctrl.h:1759:6: error: using typedef-name âxc_error_codeâ after âenumâ
Âenum xc_error_code {
ÂÂÂÂÂ ^
/usr/include/xenctrl.h:122:28: note: âxc_error_codeâ has a previous declaration here
Âtypedef enum xc_error_code xc_error_code;
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ^
/usr/include/xenctrl.h:1770:8: error: using typedef-name âxc_error_codeâ after âenumâ
ÂÂ enum xc_error_code code;
ÂÂÂÂÂÂÂ ^
/usr/include/xenctrl.h:122:28: note: âxc_error_codeâ has a previous declaration here
Âtypedef enum xc_error_code xc_error_code;

I looked at xenctrl.h and the typedef is put before the declaration of the enum :

typedef enum xc_error_code xc_error_code;

...

enum xc_error_code {
 XC_ERROR_NONE = 0,
 XC_INTERNAL_ERROR = 1,
 XC_INVALID_KERNEL = 2,
 XC_INVALID_PARAM = 3,
 XC_OUT_OF_MEMORY = 4,
 /* new codes need to be added to xc_error_level_to_desc too */
};

I swapped the two declarations and that works just fine :

enum xc_error_code {
 XC_ERROR_NONE = 0,
 XC_INTERNAL_ERROR = 1,
 XC_INVALID_KERNEL = 2,
 XC_INVALID_PARAM = 3,
 XC_OUT_OF_MEMORY = 4,
 /* new codes need to be added to xc_error_level_to_desc too */
};

typedef enum xc_error_code xc_error_code;

Best regards,

Sebastien Fremal

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel