Re: [Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 31/08/15 12:06, vijay.kilari@xxxxxxxxx wrote:
> +static int vgic_v3_gits_lpi_mmio_read(struct vcpu *v, mmio_info_t *info)

[...]

> +    /* Neglect if not LPI. */
> +    if ( offset < FIRST_GIC_LPI )
> +    {
> +        *r = 0;
> +        return 1;
> +    }

[...]

> +static int vgic_v3_gits_lpi_mmio_write(struct vcpu *v, mmio_info_t *info)
> +{

[...]

> +    /* Neglect if not LPI. */
> +    if ( offset < FIRST_GIC_LPI )
> +        return 1;

Based on the spec, those 2 checks are wrong and make impossible to use
LPIs. Please test this patch series before sending it on the ML.

Regards,


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel