Re: [Xen-devel] [PATCH v6 12/18] x86: move some APIC related macros to apicdef.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.15 at 03:57, <feng.wu@xxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/apicdef.h
> +++ b/xen/include/asm-x86/apicdef.h
> @@ -124,6 +124,10 @@
>  
>  #define MAX_IO_APICS 128
>  
> +#define APIC_SHORT_MASK                  0xc0000
> +#define APIC_DEST_NOSHORT                0x0
> +#define APIC_DEST_MASK                   0x800

Moving them into this header is certainly the right thing to do, but
please put them where they belong inside the header (i.e. the first
next to ACPI_DEST_{SELF,ALLINC,ALLBUT} and the latter before
or after APIC_DEST_{LOGICAL,PHYSICAL}.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel