Re: [Xen-devel] [PATCH v6 09/18] VT-d: Remove pointless casts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.15 at 03:57, <feng.wu@xxxxxxxxx> wrote:
> Remove pointless casts.

Much appreciated, but ...

> @@ -281,11 +280,10 @@ static void dump_iommu_info(unsigned char key)
>  
>                  printk("   %02x:  %04x   %x    %x   %x   %x   %x    %x"
>                      "    %x     %02x\n", i,
> -                    (u32)remap->index_0_14 | ((u32)remap->index_15 << 15),
> -                    (u32)remap->format, (u32)remap->mask, 
> (u32)remap->trigger,
> -                    (u32)remap->irr, (u32)remap->polarity,
> -                    (u32)remap->delivery_status, (u32)remap->delivery_mode,
> -                    (u32)remap->vector);
> +                    remap->index_0_14 | ((u32)remap->index_15 << 15),

... why are you retaining this one?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel