Re: [Xen-devel] [OSSTEST PATCH 13/13] Planner: ms-queuedaemon: Restart planning when resources become free

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-09-02 at 16:45 +0100, Ian Jackson wrote:

/me takes a deep breath...

> With this arrangemernt we can generate two reports: a `plan' report

"arrangement"

> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  README.planner |    8 +++++
>  ms-queuedaemon |   98 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++--

I think you may want to add some stuff to .gitignore, data-projection.pl is
the main one I can think of.

> +proc restarter-maybe-provoke-restart {newly_free} {
> +    set newly_free {}
> +    global wasfree
> +    for-free-resources freeres {
> +     if {[info exists wasfree($freeres)]} continue
> +     lappend newly_free $freeres
> +     set wasfree($freeres) 1
> +    }
> +    if {!$newly_free} {
> +     log-event "restarter-maybe-provoke-restart nothing"
> +     return
> +    }
> + 
> +    walker-runvars plan

ITYM walker-globals?

> +
> +proc restarter-restart-now {} {
> +    # We restart the `plan' walker.  Well, actually, if the #

Comment wrap damage? ("#" at the end)

> +    # `projection' walker is not running, we transfer the `plan'
> +    # walker to it.  At this stage the plan walker is not thinking so
> +    # there are no outstanding callbacks to worry about.
> +
> +    report-plan plan plan
> +
> +    global projection/queue_running
> +    global plan/queue_running
> +
> +    if {![info exists projection/queue_running]} {
> +     log-event "queuerun-restart-now projection-idle continue-as"
> +     set projection/queue_running [set plan/queue_running]

What sort of language names the "get" function "set" :-P

I didn't spot anything else strange.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel