[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 08/31] xen/arm: ITS: Introduce msi_desc for LPIs

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@xxxxxxxxx wrote:
From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Define msi_desc structure for arm and introduce
helper functions to access msi_desc member variables.

IHMO none of those helpers are useful in the code given you are only using in an handful number of places and they can't be optimized out.

Most of the time, you will have 2-3 times within the same function the msi_desc. So it means 6 functions call rather than directly access the msi_desc from the irq_desc.

Although, I guess we could rework later, so for now:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.