Re: [Xen-devel] [PATCH v6 05/31] xen/arm: Rename NR_IRQs and vgic_num_irqs helper function

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>
> NR_IRQS define signifies number of SGIs, PPIs and SPIs.
I don' think signifies is the right word here. And I would mention that 
SGIs/PPIs/SPIs are an IRQ lines in order to make clear why we change the 
name. I.e:
"NR_IRQS represents the number of lines (i.e SGIs, PPIs and SPIs)".


> With introduction of LPIs, NR_IRQs is renamed to NR_LINE_IRQs.
      ^ the

> Similarly vgic_num_irqs() is renamed as vgic_num_line_irqs().
The proper name is "interrupt line" or "irq line" but not "line irq" 
which doesn't make sense.
So I would prefer to see NR_IRQ_LINES or NR_ITLINES. Note that the 
latter is the best given that it's the name used within the spec.
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> ---
[...]

> diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h
> index f33c331..cbdc1ab 100644
> --- a/xen/include/asm-arm/irq.h
> +++ b/xen/include/asm-arm/irq.h
> @@ -19,11 +19,12 @@ struct arch_irq_desc {
>   };
>
>   #define NR_LOCAL_IRQS 32
> -#define NR_IRQS                1024
> +/* Number of SGIs+PPIs+SPIs */
Space before and after each '+'

> +#define NR_LINE_IRQS   1024
>
> -#define nr_irqs NR_IRQS
> -#define nr_static_irqs NR_IRQS
> -#define arch_hwdom_irqs(domid) NR_IRQS
> +#define nr_irqs NR_LINE_IRQS
> +#define nr_static_irqs NR_LINE_IRQS
> +#define arch_hwdom_irqs(domid) NR_LINE_IRQS
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel