[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/NUMA: don't account hotplug regions

On 28/08/15 14:59, Jan Beulich wrote:
> ... except in cases where they really matter: node_memblk_range[] now
> is the only place all regions get stored. nodes[] and NODE_DATA() track
> present memory only. This improves the reporting when nodes have
> disjoint "normal" and hotplug regions, with the hotplug region sitting
> above the highest populated page. In such cases a node's spanned-pages
> value (visible in both XEN_SYSCTL_numainfo and 'u' debug key output)
> covered all the way up to top of populated memory, giving quite
> different a picture from what an otherwise identically configured
> system without and hotplug regions would report. Note, however, that
> the actual hotplug case (as well as cases of nodes with multiple
> disjoint present regions) is still not being handled such that the
> reported values would represent how much memory a node really has (but
> that can be considered intentional).
> Reported-by: Jim Fehlig <jfehlig@xxxxxxxx>
> This at once makes nodes_cover_memory() no longer consider E820_RAM
> regions covered by SRAT hotplug regions.
> Also reject self-overlaps with mismatching hotplug flags.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.