[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [DOCSDAY PATCH for-4.6] docs: Fix installation of man8 pages

c/s a430436 "docs: Support for generating man(8) pages" accidentally
failed to update to the install and clean rules for man8 pages, meaning
that c/s 7b21214 "docs: Move xentrace.8 to docs/man/xentrace.pod.8"
caused a packaging regression when it came to xentop.8

To avoid similar bugs in the future, move the generation of the build,
install and clean rules into the manpage metarule.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CC: Wei Liu <wei.liu2@xxxxxxxxxx>
 docs/Makefile |   35 +++++++++++++++++++++++------------
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git a/docs/Makefile b/docs/Makefile
index 3d77913..d25e6c7 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -58,20 +58,15 @@ else
        @echo "fig2dev (transfig) not installed; skipping figs."
-.PHONY: man-pages
-man-pages: $(DOC_MAN1) $(DOC_MAN5) $(DOC_MAN8)
 .PHONY: pdf
 pdf: $(DOC_PDF)
 .PHONY: clean
+clean: clean-man-pages
        $(MAKE) -C figs clean
        rm -rf .word_count *.aux *.dvi *.bbl *.blg *.glo *.idx *~
        rm -rf *.ilg *.log *.ind *.toc *.bak *.tmp core
        rm -rf html txt pdf
-       rm -rf man5
-       rm -rf man1
 .PHONY: distclean
 distclean: clean
@@ -80,6 +75,8 @@ distclean: clean
 # Top level install targets
+.PHONY: man-pages install-man-pages clean-man-pages
 # Metarules for generating manpages.  Run with $(1) substitued for section
@@ -110,17 +107,31 @@ else
        @echo "pod2text not installed; skipping $$@"
+# Build
+.PHONY: man$(1)-pages
+man$(1)-pages: $$(DOC_MAN$(1))
+# Install
+.PHONY: install-man$(1)-pages
+install-man$(1)-pages: man$(1)-pages
+       $(INSTALL_DIR) $(DESTDIR)$(mandir)
+       cp -r man$(1) $(DESTDIR)$(mandir)
+# Clean
+.PHONY: clean-man$(1)-pages
+       rm -rf man$(1)
+# Link buld/install/clean to toplevel rules
+man-pages: man$(1)-pages
+install-man-pages: install-man$(1)-pages
+clean-man-pages: clean-man$(1)-pages
 # Generate manpage rules for each section
 $(foreach i,1 5 8,$(eval $(call GENERATE_MANPAGE_RULES,$(i))))
-.PHONY: install-man-pages
-install-man-pages: man-pages
-       $(INSTALL_DIR) $(DESTDIR)$(mandir)
-       cp -R man1 $(DESTDIR)$(mandir)
-       cp -R man5 $(DESTDIR)$(mandir)
 .PHONY: install-html
 install-html: html txt figs
        $(INSTALL_DIR) $(DESTDIR)$(docdir)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.