Re: [Xen-devel] [PATCH] x86/MSI: don't flag non-maskable entries a host-masked

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Aug 26, 2015 at 07:50:24AM -0600, Jan Beulich wrote:
> 'M' debug key output looks confusing without this adjustment.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
>          entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
>          entry[i].msi_attrib.is_64 = is_64bit_address(control);
>          entry[i].msi_attrib.entry_nr = i;
> +        entry[i].msi_attrib.host_masked =
>          entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> -        entry[i].msi_attrib.host_masked = 1;
>          entry[i].msi_attrib.guest_masked = 0;
>          entry[i].msi_attrib.pos = pos;
>          if ( entry[i].msi_attrib.maskbit )
> 
> 
> 

> x86/MSI: don't flag non-maskable entries a host-masked

s/a/as/ ?

> 
> 'M' debug key output looks confusing without this adjustment.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
>          entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
>          entry[i].msi_attrib.is_64 = is_64bit_address(control);
>          entry[i].msi_attrib.entry_nr = i;
> +        entry[i].msi_attrib.host_masked =
>          entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> -        entry[i].msi_attrib.host_masked = 1;
>          entry[i].msi_attrib.guest_masked = 0;
>          entry[i].msi_attrib.pos = pos;
>          if ( entry[i].msi_attrib.maskbit )

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel