Re: [Xen-devel] [PATCH V4 1/4] x86/xsaves: add basic definitions/helpers to support xsaves

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.08.15 at 11:47, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 25/08/2015 11:54, Shuai Ruan wrote:
>> --- a/xen/include/asm-x86/cpufeature.h
>> +++ b/xen/include/asm-x86/cpufeature.h
>> @@ -153,6 +153,10 @@
>>  #define X86_FEATURE_RDSEED  (7*32+18) /* RDSEED instruction */
>>  #define X86_FEATURE_ADX             (7*32+19) /* ADCX, ADOX instructions */
>>  #define X86_FEATURE_SMAP    (7*32+20) /* Supervisor Mode Access Prevention 
>> */
>> +#define XSAVEOPT            (1 << 0)
>> +#define XSAVEC                      (1 << 1)
>> +#define XGETBV1             (1 << 2)
>> +#define XSAVES                      (1 << 3)
> 
> This absolutely must be X86_FEATURE_* for consistency, and you will need
> to introduce a new capability word.

Or even better re-use word 2.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel