[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86/HVM: honor p2m_ram_ro in hvm_map_guest_frame_rw()
On 08/14/2015 06:38 AM, Jan Beulich wrote: On 31.07.15 at 18:06, <boris.ostrovsky@xxxxxxxxxx> wrote:On 07/24/2015 05:41 AM, Jan Beulich wrote:@@ -1693,14 +1703,22 @@ int nvmx_handle_vmclear(struct cpu_user_ else { /* Even if this VMCS isn't the current one, we must clear it. */ - vvmcs = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 0); + bool_t writable; + + vvmcs = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 0, &writable);Since you replaced 'gpa >> PAGE_SHIFT' with 'paddr_to_pfn(gpa' above, perhaps it should be replaced here too. Other than that, Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>I took the liberty to downgrade this to an ack (covering SVM) on v2 (since the SVM part didn't change). Sure. (I also reviewed v2 so you can use either tag). -boris _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |