Re: [Xen-devel] [PATCH v2 1/2] ACPI/table: Always count matched and successfully parsed entries

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.08.15 at 12:50, <julien.grall@xxxxxxxxxx> wrote:
> Hi Shannon,
> 
> On 14/08/15 04:36, Shannon Zhao wrote:
>> From: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>
>> 
>> Ported from Linux commit 4ceacd02f5a1795c5c697e0345ee10beef675290.
>> 
>> acpi_parse_entries() allows to traverse all available table entries (aka
>> subtables) by passing max_entries parameter equal to 0, but since its count
>> variable is only incremented if max_entries is not 0, the function always
>> returns 0 for max_entries equal to 0.  It would be more useful if it 
> returned
>> the number of entries matched instead, so make it increment count in that
>> case too.
>> 
>> Acked-by: Grant Likely <grant.likely@xxxxxxxxxx>
>> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>
>> Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> 
> You may want to add an indentation to show this is the commit message
> from Linux and not Xen.
> 
> One of the reason behind that it's Grant acked the patch for Linux and
> not Xen. The patch is nearly the same this time (only the lines change),
> but it may happen that we need to fix a bit.

Which is why I find it generally better to do

S-o-b:
S-o-b:
[Linux commit ...]
S-o-b:

(when no other comments need adding) which implicitly draws a line
between the Linux and Xen tags.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel