[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/x86: Clean up vm_event-related code in asm-x86/domain.h



>>> On 14.08.15 at 12:30, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 08/14/2015 01:21 PM, Jan Beulich wrote:
>>>>> On 14.08.15 at 11:54, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> @@ -460,6 +459,18 @@ typedef enum __packed {
>>>      SMAP_CHECK_DISABLED,        /* disable the check */
>>>  } smap_check_policy_t;
>>>  
>>> +/*
>>> + * Should we emulate the next matching instruction on VCPU resume
>>> + * after a vm_event?
>>> + */
>>> +struct vm_event {
>>> +    uint32_t emulate_flags;
>>> +    unsigned long gpa;
>>> +    unsigned long eip;
>>> +    struct vm_event_emul_read_data emul_read_data;
>>> +    struct monitor_write_data write_data;
>>> +};
>> 
>> ... this would better go into asm-x86/vm_event.h (despite it meaning
>> that the file will then be included by basically everything).
> 
> Ack.

And actually (having looked another time) I don't think this implies
including asm/vm_event.h from asm-x86/domain.h.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.