[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH OSSTEST v2 3/7] ts-debian-di-install: Install pv-grub-menu in ARM guests, always.



Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
v2: s/pv-menu-lst/pv-grub-menu/
    Add note that pvgrub == grub1
    Ungarble a comment
---
 ts-debian-di-install | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/ts-debian-di-install b/ts-debian-di-install
index 612e0fa..eef4681 100755
--- a/ts-debian-di-install
+++ b/ts-debian-di-install
@@ -190,9 +190,20 @@ END
 
        $method_cfg = setup_netboot($tmpdir, $arch, $suite);
 
+       # We need the pv-grub-menu package:
+       # - On x86 when running pvgrub, since pvgrub only speaks grub1
+       #   menu.lst syntax and grub2 is now the only grub in
+       #   Debian.
+       # - On ARM, which uses pygrub, because grub2 is not installed
+       #   on ARM by default (except for, maybe, UEFI guests in the
+       #   future, but not today).
+       #
+       # NB: "pvgrub" is grub1/grub-legacy, not PV grub2.
+       my $pvmenulst = ($bl eq "pvgrub" || $arch =~ /arm/);
+
        $ps_url = preseed_create_guest($gho, $arch, '',
                                       Suite=>$suite,
-                                      PvMenuLst=>($bl eq "pvgrub"));
+                                      PvMenuLst=>$pvmenulst);
 
        $extra_disk = "";
     }
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.