Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.08.15 at 18:15, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Wed, 12 Aug 2015, Jan Beulich wrote:
>> >>> On 12.08.15 at 16:47, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>> > @@ -31,8 +33,15 @@ typedef int decompress_fn(unsigned char *inbuf, 
>> > unsigned int len,
>> >   * dependent).
>> >   */
>> >  
>> > -decompress_fn bunzip2, unxz, unlzma, unlzo, unlz4;
>> > +decompress_fn perform_gunzip, bunzip2, unxz, unlzma, unlzo, unlz4;
>> >  
>> >  int decompress(void *inbuf, unsigned int len, void *outbuf);
>> >  
>> > +static inline unsigned long output_length(char *image, unsigned long 
>> > image_len)
>> 
>> Neither of the callers gets moved out of bzimage.c - why does this
>> function need to move?
> 
> We'll use it on arm.

Hmm, the way it is used on x86 makes it quite architecture specific
(namely because of the assumption that the size is also in said
place for non-gz compression methods). I'd therefore prefer code
duplication over code sharing here. 

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel