[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/hvm: Fix non-onchangeonly CR write events logic


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Wed, 12 Aug 2015 20:48:05 +0300
  • Cc: "wei.liu2@xxxxxxxxxx" <Wei.Liu2@xxxxxxxxxx>, keir@xxxxxxx, jbeulich@xxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Wed, 12 Aug 2015 17:48:25 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=AwNHGkIbeP2eoWkyG34MR+rbcJtAxQAEnN3TV/xTNW1TOhV2HYUEDLXFugyRpGQgKFPNhy0LX3WLUDdqPVAv2K7Y37zS6e/JAAv8ZXmPJpLH61+LslOx0Afpc3vEP6amoFVb5xo0qsdLkGsYkiseFiJK+mXmzqrPjW+e0SholEeFDDLhqkeBPtuzcqV+1DhIm2Rafrlzr3HgQS/U/UQpnCPmU+fqDEG0l0Agj1QOmD9SZULgQMn/hOQhInutbc5g3++fSnXf04pEE3ggv2ejRdV+F0xcvE91O7pdBI3xpyOq1MYMLCU63wCF3rDSyS2+x3frz2s+T51ZE0e0rxmWmQ==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 08/12/2015 08:45 PM, Andrew Cooper wrote:
> On 12/08/15 18:00, Razvan Cojocaru wrote:
>> hvm_event_crX() already returns a bool_t to tell us whether an
>> event will be sent out or not, so the extra check that value != old
>> is not only useless, but also prevents non-onchangeonly events from
>> being sent.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> I presume this is a 4.6 candidate?  If so, you need to CC the release
> manager as we are into the RC's

Yes, it is. I've now CCd Wei, thank you for pointing that out!
And sorry for missing this before.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.