Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test 
each new baseline"):
> diff --git a/cr-daily-branch b/cr-daily-branch
> index 4b9b525..f9edbd4 100755
> --- a/cr-daily-branch
> +++ b/cr-daily-branch
> @@ -100,6 +100,13 @@ if [ "x$OSSTEST_BASELINES_ONLY" = xy ] ; then
>      force_baseline=baselines-only
>      wantpush=false
>      skipidentical=true
> +    if [ "x$treeurl" != xnone: ]; then
> +     treearg=--tree-$tree=$treeurl
> +    fi
> +    tested_revision=`check_tested $treearg --print-revision=$tree`
> +    if [ "x$tested_revision" != x ]; then
> +     OLD_REVISION="$tested_revision"
> +    fi

This is strikingly similar to the code inside
   if [ "x$OSSTEST_NO_BASELINE" != xy ] ; then
near line 99.

Maybe, instead, you should nobble the
     if [ "x$OLD_REVISION" = x ]; then
bit which sets OLD_REVISION, somehow, and then the later code is
nearly right.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel