Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw() adjustments

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/08/15 15:16, Jan Beulich wrote:
> ... and its callers.
>
> While all non-nested users are made fully honor the semantics of that
> type, doing so in the nested case seemed insane (if doable at all,
> considering VMCS shadowing), and hence there the respective operations
> are simply made fail.
>
> One case not (yet) taken care of is that of a page getting transitioned
> to this type after a mapping got established.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, with one style
correction...

> @@ -4071,11 +4082,11 @@ void hvm_task_switch(
>      v->arch.hvm_vcpu.guest_cr[0] |= X86_CR0_TS;
>      hvm_update_guest_cr(v, 0);
>  
> -    if ( (taskswitch_reason == TSW_iret) ||
> -         (taskswitch_reason == TSW_jmp) )
> +    if ( (taskswitch_reason == TSW_iret ||
> +          taskswitch_reason == TSW_jmp) && otd_writable)

Space.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel