Re: [Xen-devel] [PATCH OSSTEST 5/7] Debian: ARM: only apply no bootloader workaround if xopts{PvMenuLst}

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST 5/7] Debian: ARM: only apply no bootloader 
workaround if xopts{PvMenuLst}"):
> This workaround is only necessary because of how pv-menu-list works,
> so we should only apply both or neither of them.
> 
> This results in a long line and I'm about to add a second workaround
> to this block, so switch to a regular if block instead of postfixing
> on the one command. Move the comment inside that block in preparation
> for other workarounds as well.
...
> +    if ($xopts{PvMenuLst} && $arch =~ /^arm/ &&
> +     $suite =~ /wheezy|jessie|sid/ ) {

If you're going to wrap this I would mildly prefer /all/ the &&s to
generate a newline, so it is clearer that it's a 3-factor expression.

But, regardless,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel